solana icon indicating copy to clipboard operation
solana copied to clipboard

Feature Impl: cost model uses number of requested write locks

Open apfitzge opened this issue 5 months ago • 2 comments

Problem

Implementation of #34819

Summary of Changes

  • Some write-locks are demoted to read-locks during transaction sanitization
  • Change the cost model to apply write lock costs for the number of requested write locks, instead of the number of write-locks after demotion
  • Requires feature-gate so that activation of 2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj ( https://github.com/solana-labs/solana/issues/29595) will not cause this change to break consensus

Fixes #

apfitzge avatar Jan 18 '24 00:01 apfitzge

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (9d13244) 81.7% compared to head (4ea6629) 81.7%. Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34820     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         826      826             
  Lines      223114   223205     +91     
=========================================
+ Hits       182335   182399     +64     
- Misses      40779    40806     +27     

codecov[bot] avatar Jan 18 '24 01:01 codecov[bot]

@taozhu-chicago sorry had to rebase because of conflict in adding features to feature-set

apfitzge avatar Jan 19 '24 18:01 apfitzge