solana
solana copied to clipboard
separate priority fee and transaction fee from fee calculation
Problem
To reward priority fee differently from transaction fee (SIMD-0096), priority fee should be separated from return of calculate_fee(...)
.
Summary of Changes
- change
calculate_fee()
return type fromu64
toFeeDetails
- no other functional changes.
Fixes #
Codecov Report
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
51c0649
) 81.6% compared to head (f84b315
) 81.6%. Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #34757 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 830 830
Lines 224746 224757 +11
=======================================
+ Hits 183515 183547 +32
+ Misses 41231 41210 -21
can this wait for 1.19? should be able to cut 1.18 in ~1wk if all goes well with mb 1.17 adoption, making this mergeable into master
can this wait for 1.19? should be able to cut 1.18 in ~1wk if all goes well with mb 1.17 adoption, making this mergeable into master
1.19 sounds good, need time to test anyway.