solana icon indicating copy to clipboard operation
solana copied to clipboard

separate priority fee and transaction fee from fee calculation

Open tao-stones opened this issue 5 months ago • 3 comments

Problem

To reward priority fee differently from transaction fee (SIMD-0096), priority fee should be separated from return of calculate_fee(...).

Summary of Changes

  • change calculate_fee() return type from u64 to FeeDetails
  • no other functional changes.

Fixes #

tao-stones avatar Jan 11 '24 21:01 tao-stones

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (51c0649) 81.6% compared to head (f84b315) 81.6%. Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34757   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         830      830           
  Lines      224746   224757   +11     
=======================================
+ Hits       183515   183547   +32     
+ Misses      41231    41210   -21     

codecov[bot] avatar Jan 11 '24 23:01 codecov[bot]

can this wait for 1.19? should be able to cut 1.18 in ~1wk if all goes well with mb 1.17 adoption, making this mergeable into master

t-nelson avatar Jan 12 '24 22:01 t-nelson

can this wait for 1.19? should be able to cut 1.18 in ~1wk if all goes well with mb 1.17 adoption, making this mergeable into master

1.19 sounds good, need time to test anyway.

tao-stones avatar Jan 12 '24 23:01 tao-stones