solana icon indicating copy to clipboard operation
solana copied to clipboard

don't serialize executable accounts

Open seanyoung opened this issue 2 years ago • 1 comments

Problem

executable accounts can be large, and programs have no need for the raw elf bytes during runtime. So, serialize those accounts as zero length.

On mainnet beta there a few program_ids that do not work with this feature. For them, provide an exception list under another feature.

Enabling this would prevent further programs from depending on the elf text. It should also provide a performance increase.

Summary of Changes

Fixes #

seanyoung avatar Jan 08 '24 11:01 seanyoung

Codecov Report

Attention: Patch coverage is 82.69231% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 81.7%. Comparing base (31a73ab) to head (e85152d). Report is 16 commits behind head on master.

:exclamation: Current head e85152d differs from pull request most recent head 51f6be2. Consider uploading reports for the commit 51f6be2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34686   +/-   ##
=======================================
  Coverage    81.7%    81.7%           
=======================================
  Files         834      834           
  Lines      224197   224253   +56     
=======================================
+ Hits       183287   183345   +58     
+ Misses      40910    40908    -2     

codecov[bot] avatar Jan 10 '24 17:01 codecov[bot]

This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave

willhickey avatar Mar 03 '24 04:03 willhickey