solana icon indicating copy to clipboard operation
solana copied to clipboard

BankingStage: set reasonable bound on max received packets per call

Open apfitzge opened this issue 6 months ago • 1 comments

Problem

If the buffer is empty when many packets are in the sigverify channel, a single receive call may receive too many packets and lead to that thread missing a large fraction of a slot.

Summary of Changes

Bound the maxmimum number of packets to receive per call as 10k, or 2k if above half capacity.

Fixes #

apfitzge avatar Jan 02 '24 17:01 apfitzge

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5349308) 81.8% compared to head (7eed319) 81.8%. Report is 334 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34622   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         824      824           
  Lines      222260   222263    +3     
=======================================
+ Hits       181910   181914    +4     
+ Misses      40350    40349    -1     

codecov[bot] avatar Jan 02 '24 18:01 codecov[bot]