solana icon indicating copy to clipboard operation
solana copied to clipboard

count precompiled programs signatures to transaction cost

Open tao-stones opened this issue 1 year ago • 4 comments

Problem

Cost of signatures can be cleaner

Summary of Changes

  • refactor to simplify it by using SanitizedMessage

Fixes #

tao-stones avatar Dec 19 '23 18:12 tao-stones

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6f0133b) 81.8% compared to head (f58d69d) 81.8%. Report is 429 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34524   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         820      820           
  Lines      221055   221053    -2     
=======================================
+ Hits       180887   180962   +75     
+ Misses      40168    40091   -77     

codecov[bot] avatar Dec 19 '23 19:12 codecov[bot]

This will need a feature gate right? It will affect replay when we check the cost model there

#29595 is currently blocked per feature schedule. But if it lands after that one, then yea, need feature gate for it.

tao-stones avatar Dec 21 '23 16:12 tao-stones

This will need a feature gate right? It will affect replay when we check the cost model there

#29595 is currently blocked per feature schedule. But if it lands after that one, then yea, need feature gate for it.

even if it doesn't, the min version for that feature needs bumped to whatever this lands in

t-nelson avatar Dec 21 '23 20:12 t-nelson

This will need a feature gate right? It will affect replay when we check the cost model there

#29595 is currently blocked per feature schedule. But if it lands after that one, then yea, need feature gate for it.

even if it doesn't, the min version for that feature needs bumped to whatever this lands in

good reminder!

I'll leave this PRT as Draft until measured execution costs for both programs, update block_cost_limits.rs before moving to Ready for Review.

tao-stones avatar Dec 21 '23 23:12 tao-stones

close it, will be addressed in other changes

tao-stones avatar Feb 21 '24 19:02 tao-stones