solana icon indicating copy to clipboard operation
solana copied to clipboard

Failing unit tests for quic implementation on mac

Open KirillLykov opened this issue 3 years ago • 4 comments

Problem

It looks like unit tests for streamer are failing for master but only on Mac M1. Commit 6f2e556b1653a5cd34418a705d9aa4f50eb295e5

failures:

---- nonblocking::quic::test::test_quic_server_unstaked_connection_removal stdout ----
thread 'nonblocking::quic::test::test_quic_server_unstaked_connection_removal' panicked at 'assertion failed: `(left == right)`
  left: `0`,
 right: `1`', streamer/src/nonblocking/quic.rs:1251:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- nonblocking::quic::test::test_quic_server_zero_staked_connection_removal stdout ----
thread 'nonblocking::quic::test::test_quic_server_zero_staked_connection_removal' panicked at 'assertion failed: `(left == right)`
  left: `0`,
 right: `1`', streamer/src/nonblocking/quic.rs:1233:9

---- nonblocking::quic::test::test_quic_server_staked_connection_removal stdout ----
thread 'nonblocking::quic::test::test_quic_server_staked_connection_removal' panicked at 'assertion failed: `(left == right)`
  left: `0`,
 right: `1`', streamer/src/nonblocking/quic.rs:1206:9


failures:
    nonblocking::quic::test::test_quic_server_staked_connection_removal
    nonblocking::quic::test::test_quic_server_unstaked_connection_removal
    nonblocking::quic::test::test_quic_server_zero_staked_connection_removal

test result: FAILED. 46 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out; finished in 34.09s

Proposed Solution

KirillLykov avatar Sep 06 '22 16:09 KirillLykov

Are you on an intel mac? I'm not seeing these tests fail on my arm mac, FYI. Just ran off of c04747dd

apfitzge avatar Sep 09 '22 15:09 apfitzge

Are you on an intel mac? I'm not seeing these tests fail on my arm mac, FYI. Just ran off of c04747d

No, I'm on M1 Pro. I've tried your commit -- the same 4 tests in streamer. I'm using cargo 1.63.0 (fd9c4297c 2022-07-01).

Interestingly, when I run with --release there are 5 tests failing:

    nonblocking::quic::test::test_quic_server_unstaked_connection_removal
    nonblocking::quic::test::test_quic_server_zero_staked_connection_removal
    nonblocking::recvmmsg::tests::test_recv_mmsg_multi_addrs
    nonblocking::recvmmsg::tests::test_recv_mmsg_multi_iter
    nonblocking::recvmmsg::tests::test_recv_mmsg_multi_iter_timeout

I wonder if rust uses llvm pre-installed on the mac, if yes it has version 13.

KirillLykov avatar Sep 10 '22 09:09 KirillLykov

interestingly, some tests are failing always (nonblocking::quic::test::test_quic_server_staked_connection_removal), while others (recvmmsg::tests::test_recv_mmsg_multi_iter_timeout) are failing sometimes

KirillLykov avatar Sep 18 '22 13:09 KirillLykov

Spin off https://github.com/solana-labs/solana/issues/27917

KirillLykov avatar Sep 19 '22 16:09 KirillLykov