solana icon indicating copy to clipboard operation
solana copied to clipboard

web3: restructure files into more directories

Open jstarry opened this issue 1 year ago • 1 comments

Summary of Changes

  • Added the transaction and message directories that will hold new code that will be added soon to support versioned transactions.
  • Added the programs and program-tests directories to make it easier to see which programs are supported by this library
  • Renamed util directory to utils

Fixes #

jstarry avatar Aug 11 '22 09:08 jstarry

Codecov Report

Merging #27080 (441c4cc) into master (1165a7f) will decrease coverage by 4.3%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #27080       +/-   ##
===========================================
- Coverage    81.9%    77.5%     -4.4%     
===========================================
  Files         631       46      -585     
  Lines      174252     2469   -171783     
  Branches        0      352      +352     
===========================================
- Hits       142728     1915   -140813     
+ Misses      31524      424    -31100     
- Partials        0      130      +130     

codecov[bot] avatar Aug 11 '22 09:08 codecov[bot]

More module boundaries the better!

steveluscher avatar Aug 12 '22 03:08 steveluscher

Thanks for totally screwing my future rebase of https://github.com/solana-labs/solana/pull/25839 tho. 😘

steveluscher avatar Aug 12 '22 03:08 steveluscher

Thanks for totally screwing my future rebase of https://github.com/solana-labs/solana/pull/25839 tho. 😘

Oh dang, I forgot to follow up on that. Let's definitely get yours in first. This restructure isn't that pressing

jstarry avatar Aug 12 '22 07:08 jstarry

Sorry @steveluscher, I'd like to get this in first. Feel free to squash the commits in your nonce pr to avoid resolving merge conflicts for each one

jstarry avatar Aug 12 '22 16:08 jstarry

Oh, by all means. No problem. Rebases are afraid of me, not the other way around.

steveluscher avatar Aug 13 '22 20:08 steveluscher