solana icon indicating copy to clipboard operation
solana copied to clipboard

Published 20 hours ago • verified publisher icon solana-labs

Support tpu use quic in net scripts

Open lijunwangs opened this issue 1 year ago • 1 comments

Support passing --tpu-use-quic in validator launched by net scripts

lijunwangs avatar Aug 09 '22 19:08 lijunwangs

I think bench-tps client requires option to enable quic as well, otherwise user will need to remember to enable it manually (./net.sh start -c bench-tps=1="--tpu-use-quic")

Another thing is that it looks like quic will become default soon and option will be tpu-disable-quic quic by default PR. So these options in script will probably require renaming.

KirillLykov avatar Aug 10 '22 17:08 KirillLykov

@lijunwangs , looks like now QUIC is default ( https://github.com/solana-labs/solana/pull/27194). I think having option --tpu-disable-quic would be beneficial also for these scripts

KirillLykov avatar Aug 23 '22 13:08 KirillLykov

@lijunwangs , looks like now QUIC is default ( #27194). I think having option --tpu-disable-quic would be beneficial also for these scripts

Yes, it is funny -- I turned it to tpu-disable-quic now

lijunwangs avatar Aug 24 '22 00:08 lijunwangs

Thanks for flopping! It looks like multinode-demo/validator.sh needs updating as well. Do you mind?

Sure. I will take care of it. I am testing this. I found the cluster would not start up with --tpu-disable-quic turned on. Still debugging.

lijunwangs avatar Aug 24 '22 02:08 lijunwangs

Thanks for flopping! It looks like multinode-demo/validator.sh needs updating as well. Do you mind?

Sure. I will take care of it. I am testing this. I found the cluster would not start up with --tpu-disable-quic turned on. Still debugging.

It turns out the missing change multinode-demo/validator.sh was causing the issue as the member validator was started with default quic and the bootstrap was started with quic disabled.

lijunwangs avatar Aug 24 '22 15:08 lijunwangs