solana icon indicating copy to clipboard operation
solana copied to clipboard

explorer add toggle for token balances owner column

Open Arrowana opened this issue 1 year ago • 4 comments

Problem

In most cases tokens are transferred, so the explorer should allow reading the most common data a user would want to see.

Unfortunately there isn't enough space to display address + owner, possibly one is enough

Summary of Changes

Add a toggle to allow displaying owner rather than address under token balances. Also remove "name" from token label, it is unnecessarily over verbose, symbol is enough.

Let me know if we want to default to owner rather than address. I wonder if this the toggle state should be saved in local storage. So user can multiple txs without having to toggle again and again.

A tx i found in Jito dashboard https://explorer.solana.com/tx/2DTWtf7RVFAFW7TtZtp4b2mmKF53Z3d6h5KRFvyNiUF8FZSWNnrtZtXWL4Ww1LFnL9o6t9Pjw3rWTaGaPsa6bv4b

stSOL => wSOL => stSOL arbitrage, we can see how messy things can get if we have to mentally convert each address to its owner.

Fixes #

Arrowana avatar Jul 19 '22 06:07 Arrowana

Neat! Can you paste in a quick screencast of this feature? Command-Shift-5 on Mac to take a screen recording.

steveluscher avatar Jul 20 '22 19:07 steveluscher

Neat! Can you paste in a quick screencast of this feature? Command-Shift-5 on Mac to take a screen recording.

https://www.loom.com/share/875bcd4c818443afa40f87b27f39f996

I am not extremely satisfied with the ergonomics. Do you think it is reasonable to follow an approach like in /inspect, while we make owner the primary thing and the actual address is shown below, so "'Owner' Address 'Address'"

Screenshot from 2022-07-21 08-54-28

Looking more closely at it, what Solscan is showing is an extract of the token transfers, which could be another section

https://solscan.io/tx/2DTWtf7RVFAFW7TtZtp4b2mmKF53Z3d6h5KRFvyNiUF8FZSWNnrtZtXWL4Ww1LFnL9o6t9Pjw3rWTaGaPsa6bv4b

Arrowana avatar Jul 20 '22 23:07 Arrowana

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 31 '22 06:07 stale[bot]

Let me know if we want to default to owner rather than address.

This sounds good to me!

Also remove "name" from token label, it is unnecessarily over verbose, symbol is enough.

I personally like having the name in there, but maybe it could move to a tooltip? Should add the logo in there too. Do you mind reverting this specific change and applying it in a new PR so we can put more thought into what's best here?

And lastly, rather than a toggle, do you mind using a dropdown like we do in "Token Holdings" section on the account details page? Then we should put the dropdown option in the url params so that the page is shareable.

jstarry avatar Aug 06 '22 15:08 jstarry

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Aug 14 '22 01:08 stale[bot]