solana-web3.js icon indicating copy to clipboard operation
solana-web3.js copied to clipboard

Show no Turbo logs except when there is an error

Open steveluscher opened this issue 1 year ago • 2 comments

Summary

So many logs.

How would you folks feel about Turborepo showing nothing unless there's an error?

• Packages in scope: @solana/accounts, @solana/addresses, @solana/assertions, @solana/build-scripts, @solana/codecs, @solana/codecs-core, @solana/codecs-data-structures, @solana/codecs-numbers, @solana/codecs-strings, @solana/compat, @solana/crypto-impl, @solana/errors, @solana/functional, @solana/instructions, @solana/keys, @solana/options, @solana/programs, @solana/rpc, @solana/rpc-api, @solana/rpc-graphql, @solana/rpc-parsed-types, @solana/rpc-spec, @solana/rpc-spec-types, @solana/rpc-subscriptions, @solana/rpc-subscriptions-api, @solana/rpc-subscriptions-spec, @solana/rpc-subscriptions-transport-websocket, @solana/rpc-transformers, @solana/rpc-transport-http, @solana/rpc-types, @solana/signers, @solana/sysvars, @solana/test-config, @solana/test-matchers, @solana/text-encoding-impl, @solana/transaction-confirmation, @solana/transactions, @solana/tsconfig, @solana/web3.js, @solana/web3.js-experimental, @solana/web3.js-legacy-sham, @solana/webcrypto-ed25519-polyfill, @solana/ws-impl
• Running test:lint in 43 packages
• Remote caching enabled
@solana/accounts:test:lint: cache miss, executing 9db95c74ecbf331c
@solana/accounts:test:lint:
@solana/accounts:test:lint: > @solana/[email protected] test:lint /home/sol/src/solana-web3.js-git/packages/accounts
@solana/accounts:test:lint: > jest -c ../../node_modules/@solana/test-config/jest-lint.config.ts --rootDir . --silent
@solana/accounts:test:lint:
                             PASS   ESLint  src/rpc-api/common.ts
@solana/accounts:test:lint:  PASS   ESLint  src/types/global.d.ts
@solana/accounts:test:lint:  PASS   ESLint  src/index.ts
@solana/accounts:test:lint:  PASS   ESLint  src/maybe-account.ts
@solana/accounts:test:lint:  PASS   ESLint  src/parse-account.ts
@solana/accounts:test:lint:  PASS   ESLint  src/account.ts
@solana/accounts:test:lint:  FAIL   ESLint  src/decode-account.ts
@solana/accounts:test:lint:
@solana/accounts:test:lint: /home/sol/src/solana-web3.js-git/packages/accounts/src/decode-account.tsa/accounts:test:lint:
@solana/accounts:test:lint:   68:9  error  Unexpected constant condition  no-constant-conditionsolana/accounts:test:lint:
@solana/accounts:test:lint:
@solana/accounts:test:lint: ✖ 1 problem (1 error, 0 warnings)
@solana/accounts:test:lint:
@solana/accounts:test:lint:  PASS   ESLint  src/__typetests__/maybe-account-typetest.ts
@solana/accounts:test:lint:  PASS   ESLint  src/rpc-api/getAccountInfo.ts
@solana/accounts:test:lint:  PASS   ESLint  src/__tests__/decode-account-test.ts
@solana/accounts:test:lint:  PASS   ESLint  src/__typetests__/fetch-account-typetest.ts
@solana/accounts:test:lint:  PASS   ESLint  src/__tests__/parse-account-test.ts
@solana/accounts:test:lint:  PASS   ESLint  src/__typetests__/decode-account-typetest.ts
@solana/accounts:test:lint:  PASS   ESLint  src/__tests__/fetch-account-test.ts
@solana/accounts:test:lint:  PASS   ESLint  src/__typetests__/parse-account-typetest.ts
@solana/accounts:test:lint:  PASS   ESLint  src/rpc-api/index.ts
@solana/accounts:test:lint:  PASS   ESLint  src/__tests__/maybe-account-test.ts
@solana/accounts:test:lint:  PASS   ESLint  src/__tests__/__setup__.ts
@solana/accounts:test:lint:  PASS   ESLint  src/rpc-api/getMultipleAccounts.ts
@solana/accounts:test:lint:  PASS   ESLint  src/fetch-account.ts

@solana/accounts:test:lint: Test Suites: 1 failed, 19 passed, 20 total
@solana/accounts:test:lint: Tests:       1 failed, 19 passed, 20 total
@solana/accounts:test:lint: Snapshots:   0 total
@solana/accounts:test:lint: Time:        1.519 s, estimated 2 s
@solana/accounts:test:lint:  ELIFECYCLE  Command failed with exit code 1.
@solana/accounts:test:lint: ERROR: command finished with error: command (/home/sol/src/solana-web3.js-git/packages/accounts) /home/sol/.local/share/pnpm/pnpm run test:lint exited (1)
@solana/accounts#test:lint: command (/home/sol/src/solana-web3.js-git/packages/accounts) /home/sol/.local/share/pnpm/pnpm run test:lint exited (1)
@solana/accounts:test:lint:
 Tasks:    38 successful, 39 total
Cached:    38 cached, 39 total
  Time:    11.009s st:lint:
Failed:    @solana/accounts#test:lint
@solana/accounts:test:lint:
 ERROR  run failed: command  exited (1)

Related discussion: https://github.com/vercel/turbo/issues/4042

steveluscher avatar Mar 22 '24 20:03 steveluscher

⚠️ No Changeset found

Latest commit: e94045c7a38959c676ad7908cc118d4519fda099

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 22 '24 20:03 changeset-bot[bot]

  • #2366 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

steveluscher avatar Mar 22 '24 20:03 steveluscher

I'll land this; you can reverse it with --output-logs full or --output-logs new-only.

steveluscher avatar Mar 26 '24 17:03 steveluscher

:tada: This PR is included in version 1.91.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Mar 26 '24 19:03 github-actions[bot]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

github-actions[bot] avatar Apr 11 '24 08:04 github-actions[bot]