solana-web3.js icon indicating copy to clipboard operation
solana-web3.js copied to clipboard

ComputeBudgetInstruction.decodeInstructionType requires deprecated TransactionInstruction type as argument

Open mschneider opened this issue 2 years ago • 1 comments
trafficstars

TransactionInstruction is by now a legacy format, but the ComputeBudgetInstruction parser still requires it. Probably worth triaging if other functionality has the same issue. For ComputeBudget this can be solved trivially by creating an unnamed struct with the right interface, as no accountKeys are required, but for more complex instructions, having a LUT-Resolved-Message type would probably be helpful. Was already requested here https://github.com/solana-labs/solana-web3.js/issues/1098

mschneider avatar Jun 04 '23 20:06 mschneider

You're absolutely right. The move to versioned transactions left the program and instruction parsers behind. I'm presently working on the transaction and instruction design of the new library, and will keep this sort of thing in mind as I design them.

steveluscher avatar Jun 05 '23 18:06 steveluscher

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

github-actions[bot] avatar Jun 20 '24 08:06 github-actions[bot]