solana-program-library icon indicating copy to clipboard operation
solana-program-library copied to clipboard

Published 20 hours ago • verified publisher icon solana-labs

[single-pool-stake] Remove deprecated functions from cli

Open samkim-crypto opened this issue 11 months ago • 2 comments

Problem

Solana clap-v3 utils deprecated a number of functions with version 1.18. https://github.com/solana-labs/solana-program-library/pull/6278 temporarily suppresses the warnings from deprecated functions.

Solution

Remove the deprecated functions.

samkim-crypto avatar Feb 28 '24 03:02 samkim-crypto

Was going to work on this but it uses Clap Derive not Clap Builder. Is this intentional? Could I convert to builder, and if so should this be in a separate PR?

tonton-sol avatar Mar 31 '24 15:03 tonton-sol

Thanks so much for the contribution! Clap derive is more readable and therefore, preferable over builder in general, so let's keep it derive for single-pool-stake. I have not checked yet if solana-clap-v3-utils currently has all the tools necessary to remove all the deprecated functions even for clap derive, but if not, then we can add the necessary interface to solana-clap-v3-utils.

samkim-crypto avatar Apr 01 '24 03:04 samkim-crypto