oyster icon indicating copy to clipboard operation
oyster copied to clipboard

Published 20 hours ago • verified publisher icon solana-labs

Governance: time to vote eneded calculates with cool off time

Open ochaloup opened this issue 1 year ago • 3 comments

The contract of SPL Gov works with cool off time to assert if it's time to finalize vote. https://github.com/solana-labs/solana-program-library/blob/master/governance/program/src/state/proposal.rs#L340 While there is the greater than not with 'equal' in comparision.

ochaloup avatar Mar 01 '23 08:03 ochaloup

@ochaloup is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 01 '23 08:03 vercel[bot]

@SebastianBor thanks for the review. I updated the pull request trying to follow your point. Please take a look.

  • I'm not sure about maxVotingTime setter for backwards compatibility reasons. Decided to not to add but not sure.

ochaloup avatar Mar 16 '23 06:03 ochaloup

Related change: https://github.com/solana-labs/oyster/pull/581/files

ochaloup avatar Mar 30 '23 08:03 ochaloup