oyster
oyster copied to clipboard
solana-labs
build(governance-sdk): generate commonjs and esmodules builds
Another suggestion for a potentially nice but definitely not required feature which could make things a little easier for consumers of the governance-sdk npm package
this generates an esmodules and commonjs build of the package in lib/mjs and lib/cjs respectively.
A downside is that it increases the size of the tarball hosted on npm but the upside is that there is probably less configuration etc required by users and the increased package size doesn't really affect them as unused code wouldn't get bundled into their applications anyway.
I haven't thoroughly tested this yet which is why it's a draft, but happy to over the next few days if it'd be useful.
TODO
- [ ] confirm that there is no issue with the extra package.json fields
- [ ] test package in a new node and browser-based project
@johnrees is attempting to deploy a commit to the Solana Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/solana-labs/oyster-governance/9qGcBzcp3g3sJx9w95EjvWYgfJL3
✅ Preview: https://oyster-governance-git-fork-johnrees-build-outputs-solana-labs.vercel.app
I haven't thoroughly tested this yet which is why it's a draft, but happy to over the next few days if it'd be useful.
Sounds like a good to have to me, but vercel doesn't like it :)
I haven't thoroughly tested this yet which is why it's a draft, but happy to over the next few days if it'd be useful.
Sounds like a good to have to me, but vercel doesn't like it :)
I'm actually a bit curious about why vercel is building the governance-sdk?
Shouldn't this be a job for dedicated CI tooling like github actions or travis? Or does it have some frontend code that I'm not aware of? Thanks 🙏
ah, I think I get it, nvm. It's building it alongside the packages/governance frontend