[PR commands] check-lint

Open yihau opened this issue 2 years ago • 3 comments

@check-lint: run the linter (clippy + fmt).

Sep 11 '23 07:09 yihau

we have this one atm https://github.com/solana-labs/move/blob/16ed36ab8d0815dd25372107765619078306109f/.github/workflows/llvm-ci-pre-land.yml#L42-L65

and it will be triggered either

create a PR
push new code

do we still need this command and when do you use it?

Sep 11 '23 07:09 yihau

I’m not sure about commands in general. I don’t see myself ever needing to use them. However the lint check I absolutely want to see run and pass without errors before anything is merged to GH solana-labs/move repository. I would also second making this check ‘required’ in GH repository settings, so that merging is blocked when this check hasn’t passed.

Sep 11 '23 13:09 dmakarov

let's implement this as it also sets background work for future commands to build/run specific targets.

Oct 21 '23 17:10 ksolana