governance-ui icon indicating copy to clipboard operation
governance-ui copied to clipboard

Bespoke DAO wizard: Invalid character error when fractional min tokens to create governance is used

Open SebastianBor opened this issue 3 years ago • 3 comments

Summary

Fractional value for min tokens to create governance causes error

Example

88.88 min tokens to create governance causes error

image

Error

image

SebastianBor avatar Feb 26 '22 16:02 SebastianBor

I'll work on this @SebastianBor Please assign this to me (:

ricknjacky avatar Feb 28 '22 22:02 ricknjacky

@SebastianBor

we use bn.js library in our project, specifically here, the genesis of the aforementioned error.

From the documentation:- Note: decimals are not supported in this library.

So, correct me if I am wrong but rounding off the value of token to the nearest possible integer is the only way to fix this error right?

ricknjacky avatar Mar 04 '22 19:03 ricknjacky

@SebastianBor Is this issue still open or any PR made for this, if not I can look into it

Abusayid693 avatar May 08 '22 10:05 Abusayid693