governance-ui icon indicating copy to clipboard operation
governance-ui copied to clipboard

Turning on/off a filter adds those types of proposals to the top instead of putting them all together

Open RaymondDashWu opened this issue 3 years ago • 6 comments

Before image

After adding drafts to filter image

Expected there to be various completed results as those were more recent

RaymondDashWu avatar Feb 06 '22 08:02 RaymondDashWu

Just wanted to understand the problem better...

Is the list supposed to be arranged in ascending order with all the list items??

whereas, its currrently its just pushing all the draft items in the starting oof the list items...

am i correct??

appsplash99 avatar Feb 06 '22 17:02 appsplash99

Yup that's correct. Ascending order of dates. Current logic pushes all draft items to the top.

RaymondDashWu avatar Feb 06 '22 17:02 RaymondDashWu

I can take a look at it. can you assign it to me ??

appsplash99 avatar Feb 06 '22 17:02 appsplash99

I'm not a maintainer so I don't have the power to assign that. I just noticed the bug when using the UI.

RaymondDashWu avatar Feb 06 '22 17:02 RaymondDashWu

I'll take a look at this too, I just dealt with filters, so can probably figure out how it works

masayafunakoshi1 avatar Mar 08 '22 17:03 masayafunakoshi1

Actually, it's probably better to keep the drafts at the top of the list. Because the only reason people might want to see the drafts is to access them again to deploy a proposal. So it would make sense it goes to the top.

masayafunakoshi1 avatar Mar 08 '22 18:03 masayafunakoshi1