governance-ui icon indicating copy to clipboard operation
governance-ui copied to clipboard

VSR: unlock deposit integration

Open tomjohn1028 opened this issue 1 year ago • 6 comments

  • Updates the VSR IDL to 0.2.5, which is built from this commit
  • Add support for the UnlockDeposit instruction

Questions/Concerns

  • Not all VSR instances will be upgraded to include this functionality. Should there be a VSR program ID check to validated?

In an ideal world, Realms uses on-chain IDLs and has a more flexible approach to adding proposals. I'm not sure where that is on the roadmap.

tomjohn1028 avatar Sep 13 '23 21:09 tomjohn1028

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 11:37pm

vercel[bot] avatar Sep 13 '23 21:09 vercel[bot]

Is there some way we can get the VSR version / fork using on-chain data? this stuff shouldnt show up if the version of VSR doesn't support it.

To be clear, you are running a VSR fork right? this isn't some new feature in mainline VSR?

asktree avatar Sep 14 '23 16:09 asktree

Is there some way we can get the VSR version / fork using on-chain data? this stuff shouldnt show up if the version of VSR doesn't support it.

The most fool proof way would be a hard coded list of program ID's that feature gate this instruction.

To be clear, you are running a VSR fork right? this isn't some new feature in mainline VSR?

Correct. Discussion on whether these features getting added to main VSR is TBD. So for now it's best to assume it will not make it into the main VSR repo.

tomjohn1028 avatar Sep 14 '23 18:09 tomjohn1028

Correct. Discussion on whether these features getting added to main VSR is TBD. So for now it's best to assume it will not make it into the main VSR repo.

Do you have more details what the new features are about please?

SebastianBor avatar Sep 15 '23 08:09 SebastianBor

@SebastianBor added more details to the comment in this PR https://github.com/mithraiclabs/voter-stake-registry/pull/1#issue-1865895596

tomjohn1028 avatar Sep 15 '23 11:09 tomjohn1028

@tomjohn1028 is attempting to deploy a commit to the blockworks-foundation Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 18 '23 19:09 vercel[bot]