create-solana-dapp icon indicating copy to clipboard operation
create-solana-dapp copied to clipboard

[nextjs] mobile friendly header

Open nickfrosty opened this issue 1 year ago • 5 comments

the generated nextjs app is not mobile friendly. specifically, the header and links. when the screen size gets too small, the UI breaks.

Generator used:

  • NextJS with tailwind

note: this might also apply to the react app too. I have not yet checked.

nickfrosty avatar Jan 24 '24 19:01 nickfrosty

Can i also contribute to this?

kaksv avatar Feb 06 '24 19:02 kaksv

Can i also contribute to this?

For sure, feel free to submit a PR that fixes this.

There is a contributing guide in the repo to help you set it up.

Alternatively you could scaffold a new project, make the changes and push it up to Github and I will merge them back into the templates.

beeman avatar Feb 06 '24 23:02 beeman

Alright, let me do so.

On Wed, Feb 7, 2024, 2:48 AM beeman @.***> wrote:

Can i also contribute to this?

For sure, feel free to submit a PR that fixes this.

There is a contributing guide in the repo to help you set it up.

Alternatively you could scaffold a new project, make the changes and push it up to Github and I will merge them back into the templates.

— Reply to this email directly, view it on GitHub https://github.com/solana-developers/create-solana-dapp/issues/32#issuecomment-1930961858, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIMXREINJGVII7MI2OJKUCLYSK6MBAVCNFSM6AAAAABCJKZP5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQHE3DCOBVHA . You are receiving this because you commented.Message ID: @.***>

kaksv avatar Feb 07 '24 02:02 kaksv

@beeman though I am good with the nextjs, tailwind and css, I am finding issues with Nx, any quick recommendation for farmiliarizing myself with it would be great. Otherwise I am failing to run it locally and see my changes.

kaksv avatar Feb 07 '24 06:02 kaksv

@beeman though I am good with the nextjs, tailwind and css, I am finding issues with Nx, any quick recommendation for farmiliarizing myself with it would be great. Otherwise I am failing to run it locally and see my changes.

If you have tried using the steps described here and get stuck, feel free to send me a message on Discord (linked in my GitHub profile) and I can see where specifically our docs need clarification.

Alternatively, you can make the changes in a generated project and push that up to a new repo and I'll merge them in.

beeman avatar Feb 07 '24 17:02 beeman

@nickfrosty @beeman Is this issue still open for contribution?

Afoxcute avatar Dec 29 '24 22:12 Afoxcute

@nickfrosty @beeman Is this issue still open for contribution?

It is! That said, any effort should probably go into the new iteration of the templates, based on @solana/web3.js v2.

Feel free to create a pull request that makes the header responsive in this new work-in-progress template.

beeman avatar Dec 29 '24 22:12 beeman

@nickfrosty @beeman Is this issue still open for contribution?

It is! That said, any effort should probably go into the new iteration of the templates, based on @solana/web3.js v2.

Feel free to create a pull request that makes the header responsive in this new work-in-progress template.

Can you point me to the contribution guide?

Afoxcute avatar Dec 30 '24 08:12 Afoxcute

@nickfrosty @beeman Is this issue still open for contribution?

It is! That said, any effort should probably go into the new iteration of the templates, based on @solana/web3.js v2. Feel free to create a pull request that makes the header responsive in this new work-in-progress template.

Can you point me to the contribution guide?

It looks like you found it! I'll create a guide in this repo though!

beeman avatar Dec 30 '24 16:12 beeman

Thanks to @Afoxcute the new version of the templates will have a header that's mobile-friendly!

beeman avatar Jan 02 '25 20:01 beeman