ColabFold icon indicating copy to clipboard operation
ColabFold copied to clipboard

Logic error in error handling for MMSeqs2 server connection

Open tristanic opened this issue 1 year ago • 1 comments

Hasn't actually affected me, but noticed while reading the code: in the submit() and status() methods defined in run_mmseqs2(), I believe the error_count=0 lines https://github.com/sokrypton/ColabFold/blob/0b6d4562030b057d8f6f5287497a2c007bdac548/colabfold/colabfold.py#L88 and https://github.com/sokrypton/ColabFold/blob/0b6d4562030b057d8f6f5287497a2c007bdac548/colabfold/colabfold.py#L115 should be outside their respective while loops.

tristanic avatar Nov 18 '24 13:11 tristanic

Looks like a real bug. Could you please submit a PR?

milot-mirdita avatar Nov 18 '24 17:11 milot-mirdita