maxrects-packer icon indicating copy to clipboard operation
maxrects-packer copied to clipboard

Published 20 hours ago • verified publisher icon soimy

Bugs in edgy rect placement in updateBinSize()

Open JohannesHoffmann opened this issue 1 year ago • 1 comments

This solves the bugs in #55

What have i done:

  • added fit or not fit check in extra test on rotated node to check for its better choice
  • removes padding on fit comparisons

I have doubts with the padding issue and my solution. It rotates only the fourth why not all? Is my solution correct?

JohannesHoffmann avatar Mar 13 '23 11:03 JohannesHoffmann

I have a questin right here. I struggled a lot to reproduce the bugs because in maxrects-packer.ts the option for square is false and in maxrects-bin.ts the same option is true. Was hard to find this out. Should this be the same default options?

JohannesHoffmann avatar Mar 13 '23 11:03 JohannesHoffmann