you-get icon indicating copy to clipboard operation
you-get copied to clipboard

Updated bilibili extractor to support new site code parsing

Open doublevanos opened this issue 1 year ago • 6 comments

Code now support new bilibili site when using cookies with login. Seems like site code was updated recently.

doublevanos avatar Mar 05 '23 01:03 doublevanos

Hello @doublevanos, Thanks for the Pull Request. We :heart: our contributors! Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

soimort-bot avatar Mar 05 '23 01:03 soimort-bot

没有issue,借一下楼。 老哥,你们的抖音视频还能下载吗

skisqibao avatar Mar 07 '23 08:03 skisqibao

Using cookies on bilibili will indeed cause JSON-related errors. I hope this PR can be merged quickly, or can I help with any testing?

Traceback (most recent call last):
  File "/usr/local/bin/you-get", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/you_get/__main__.py", line 92, in main
    main(**kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1870, in main
    script_main(any_download, any_download_playlist, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1762, in script_main
    download_main(
  File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1382, in download_main
    download(url, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1861, in any_download
    m.download(url, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/extractor.py", line 48, in download_by_url
    self.prepare(**kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/extractors/bilibili.py", line 211, in prepare
    initial_state = json.loads(initial_state_text)
  File "/usr/local/Cellar/[email protected]/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/__init__.py", line 339, in loads
    raise TypeError(f'the JSON object must be str, bytes or bytearray, '
TypeError: the JSON object must be str, bytes or bytearray, not NoneType

exoticknight avatar Mar 12 '23 08:03 exoticknight

Using cookies on bilibili will indeed cause JSON-related errors. I hope this PR can be merged quickly, or can I help with any testing?

Traceback (most recent call last):
  File "/usr/local/bin/you-get", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/you_get/__main__.py", line 92, in main
    main(**kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1870, in main
    script_main(any_download, any_download_playlist, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1762, in script_main
    download_main(
  File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1382, in download_main
    download(url, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1861, in any_download
    m.download(url, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/extractor.py", line 48, in download_by_url
    self.prepare(**kwargs)
  File "/usr/local/lib/python3.10/site-packages/you_get/extractors/bilibili.py", line 211, in prepare
    initial_state = json.loads(initial_state_text)
  File "/usr/local/Cellar/[email protected]/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/__init__.py", line 339, in loads
    raise TypeError(f'the JSON object must be str, bytes or bytearray, '
TypeError: the JSON object must be str, bytes or bytearray, not NoneType

yt-dlp works well for me with argument --cookies-from-browser firefox. Maybe you can try that.

yt-dlp

flyingicedragon avatar Mar 16 '23 02:03 flyingicedragon

没有issue,借一下楼。 老哥,你们的抖音视频还能下载吗

I can't use you-get to download videos in ixigua and toutiao for a long time. I think problem for douyin maybe same.

flyingicedragon avatar Mar 16 '23 02:03 flyingicedragon

Using cookies on bilibili will indeed cause JSON-related errors. I hope this PR can be merged quickly, or can I help with any testing?

Traceback (most recent call last):

File "/usr/local/bin/you-get", line 8, in

sys.exit(main())

File "/usr/local/lib/python3.10/site-packages/you_get/main.py", line 92, in main

main(**kwargs)

File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1870, in main

script_main(any_download, any_download_playlist, **kwargs)

File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1762, in script_main

download_main(

File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1382, in download_main

download(url, **kwargs)

File "/usr/local/lib/python3.10/site-packages/you_get/common.py", line 1861, in any_download

m.download(url, **kwargs)

File "/usr/local/lib/python3.10/site-packages/you_get/extractor.py", line 48, in download_by_url

self.prepare(**kwargs)

File "/usr/local/lib/python3.10/site-packages/you_get/extractors/bilibili.py", line 211, in prepare

initial_state = json.loads(initial_state_text)

File "/usr/local/Cellar/[email protected]/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/init.py", line 339, in loads

raise TypeError(f'the JSON object must be str, bytes or bytearray, '

TypeError: the JSON object must be str, bytes or bytearray, not NoneType

yt-dlp works well for me with argument --cookies-from-browser firefox. Maybe you can try that.

yt-dlp

thx for sharing! I will give it a try!

exoticknight avatar Mar 16 '23 02:03 exoticknight