python-romkan icon indicating copy to clipboard operation
python-romkan copied to clipboard

Install of romkan 0.2.1 fails

Open BarnabasSzabolcs opened this issue 2 years ago • 1 comments

pip install romkan failed in windows 10 with python 3.9.6 with the following error message:

README = open(os.path.join(here, 'README.rst')).read()
       File "C:\Python396\lib\encodings\cp1250.py", line 23, in decode
         return codecs.charmap_decode(input,self.errors,decoding_table)[0]
     UnicodeDecodeError: 'charmap' codec can't decode byte 0x83 in position 182

I could overcome this issue by setting PYTHONUTF8=1 environment variable. (In the code, encoding="utf-8" should be added to open().)

Also, there was a deprecation notice: DeprecationWarning: the imp module is deprecated in favour of importlib

BarnabasSzabolcs avatar Mar 28 '22 00:03 BarnabasSzabolcs

Wasn't fixed with #15 , the error still happens via pip or setup.py if installed on win 10 / python 3.10.8 and i suppose also on 3.9.6.

Fixed it locally where i put encoding="utf-8" in the open-statement on line 12 in the setup.py file, as @BarnabasSzabolcs states.

GregorLushaj avatar Aug 11 '23 16:08 GregorLushaj