react-native-modal-dropdown icon indicating copy to clipboard operation
react-native-modal-dropdown copied to clipboard

React Native 0.62 support

Open kesha-antonov opened this issue 4 years ago • 19 comments

Hi!

When building with RN 0.62 it gives error:

error: Error: Unable to resolve module `react-native/Libraries/vendor/core/isEmpty` from `node_modules/deprecated-react-native-listview/index.js`: react-native/Libraries/vendor/core/isEmpty could not be found within the project.

kesha-antonov avatar Mar 29 '20 15:03 kesha-antonov

@kesha-antonov https://github.com/sohobloo/react-native-modal-dropdown/pull/244 I have created PR with fix but I'm not sure if will be merged because looks like this project is not maintained anymore

irekrog avatar Mar 30 '20 06:03 irekrog

Awesome! Let's mention repo owner @irekrog

kesha-antonov avatar Mar 30 '20 10:03 kesha-antonov

you can temporarily fix this error by add this config to package.json "resolutions": { "deprecated-react-native-listview": "0.0.6" }

vipycm avatar Apr 07 '20 11:04 vipycm

you can temporarily fix this error by add this config to package.json "resolutions": { "deprecated-react-native-listview": "0.0.6" }

What to do after that? npm install? cuz it didn't work!

EDIT: turns out I had version 0.0.5 installed and thats why it didn't work. After installing v0.0.6 it worked!

Thank you!

omar-dulaimi avatar Apr 11 '20 16:04 omar-dulaimi

@omar-dulaimi How did u installed v0.0.6 of "deprecated-react-native-listview"

zepvi avatar Apr 12 '20 17:04 zepvi

@zepvi In package.json it was already a dependency like this: "deprecated-react-native-listview": "^0.0.5", So I changed it to 6 then added this line to package.json:

"resolutions": {
    "deprecated-react-native-listview": "0.0.6"
  },

then npm i

Hope it works for you!

omar-dulaimi avatar Apr 12 '20 18:04 omar-dulaimi

Just want to point out that this solution doesn't work with react-native-modal-dropdown version 0.7.0. You can fix it to 0.6.2.

zanlucathiago avatar May 05 '20 15:05 zanlucathiago

@zanlucathiago and how exactly do you do that?

palmer95 avatar Jun 10 '20 22:06 palmer95

@palmer95 You can fix it in package.json.

{ "dependencies": { "react-native-modal-dropdown": "0.6.2" } }

zanlucathiago avatar Jun 12 '20 17:06 zanlucathiago

Check out #251

Bilal-Abdeen avatar Jun 13 '20 22:06 Bilal-Abdeen

@palmer95 You can fix it in package.json.

{ "dependencies": { "react-native-modal-dropdown": "0.6.2" } }

this one is working for me

senthilkumar3282 avatar Aug 17 '20 06:08 senthilkumar3282

Just wanting to put a note that this doesn't work for RN 0.63+

uyend avatar Oct 12 '20 23:10 uyend

It didn't work with 0.7.0 and 0.6.2 Any workaround for 0.63.+ ?

Balasnest avatar Oct 22 '20 12:10 Balasnest

Any work around for 0.63+?

JayeshPatil-Dev avatar Nov 12 '20 14:11 JayeshPatil-Dev

Please remove this deprecated out of date package so people stop trying to use it!!!

tim92109 avatar Nov 16 '20 21:11 tim92109

Use v0.6.2. A good community member makes a PR instead of complaining. Just saying.

fqborges avatar Nov 19 '20 18:11 fqborges

Guessing that was aimed at me @fqborges I agree but somebody has to state the obvious too or number of packages that need updates to continue working are going to keep increasing

tim92109 avatar Jan 17 '21 15:01 tim92109

@tim92109 Sorry if it sounded aggressive, it shouldn't. And yes, you are right, someone has to state the obvious sometimes. But, try to no be so harsh on open source developers, they own you nothing.

fqborges avatar Jan 18 '21 13:01 fqborges

Advice taken, @fqborges & thanks

tim92109 avatar Jan 18 '21 17:01 tim92109