react-native-modal-dropdown icon indicating copy to clipboard operation
react-native-modal-dropdown copied to clipboard

Published 20 hours ago • verified publisher icon sohobloo

fix separator error, height dropdown error

Open vitorizkiimanda opened this issue 5 years ago • 1 comments

Separator not working, fixed by change '||' into '&&' -> logical error Dropdown height hardcoded leading to missing height modal on dynamic options number, fixed by deleting height on style -> styling error

vitorizkiimanda avatar Oct 01 '19 03:10 vitorizkiimanda

Hey @vitorizkiimanda, I'm not a contributor to this library but I can let you know that your pull request can't be considered while it includes all of these unrelated changes, including changing indentation.

Try to reduce your PR to only the lines that provide the change in behaviour, which might include line 413. Also, it's not usual practice to add a line like "* Modifiedd by vitorizkiimanda on 19/01/10." with your PR.

michaeldawson avatar May 30 '20 07:05 michaeldawson