Sorabh

Results 31 comments of Sorabh
trafficstars

> This should work, though I'm wary of making it the new way that collectors need to interact with doc values if they want to be able to take advantage...

> To avoid this per-doc overhead, I imagine that we would need to add some prefetch() API on (Numeric|SortedNumeric|Sorted|SortedSet|Binary)DocValues like @sohami suggests and require it to be called at a...

> @sohami I gave a try at a possible approach at #13450 in case you're curious. @jpountz Thanks for sharing this. Originally I was thinking the prefetch optimization only in...

> > Then before evaluating if these docs matches TwoPhaseIterator or not, we can perform prefetch on these buffered docs (via some prepareMatches mechanism on TwoPhaseIterator). > > This can...

@neetikasinghal Thanks for the proposal. Couple of suggestion: * In the preferred approach, I think we can start with not having an explicit API for the mode switch between full/partial,...

> > Can you still create a documentation issue to add details about cancellation count stats. > > Do you mean explain the task level stats(SearchTask, SearchShardTask) ? Difference between...

@kaushalmahi12 Changes LGTM. Can you please fix the conflicts in CHANGELOG.md and resolve all the workflow failures

> ❌ Gradle check result for [becc022](https://github.com/opensearch-project/OpenSearch/commit/becc022e06cd9216d6a636470d72a7f85d05227f): [FAILURE](https://build.ci.opensearch.org/job/gradle-check/41418/) > > Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure [a flaky...

May be we can update the documentation meanwhile until the enhancement is available as it was not evident currently. Other consideration could be for InMemoryStore, it can keep aggregating the...

@muzehyun This looks to be java client related functionality gap. Can you create the issue in [this repo](https://github.com/opensearch-project/opensearch-java) please ?