tapir icon indicating copy to clipboard operation
tapir copied to clipboard

#1737 Input annotated class can be empty.

Open borissmidt opened this issue 3 years ago • 2 comments

I hope this has no further implications on the macros that an empty case class is allowed. I also all Unit () i.e. empty tuple to be mapped to an empty case class ( still need to run the build once because there isn't an automated test here.)

borissmidt avatar Jan 11 '22 17:01 borissmidt

Looks good though you'll need to make the same changes to the Scala 3 implementation as well.

If you'd need to import the Scala3 flavor of tapir into intellij, change the ideSkipProject setting in build.sbt to:

ideSkipProject := (scalaVersion.value == scala2_12) || (scalaVersion.value == scala2_13) || thisProjectRef.value.project.contains("JS"),

adamw avatar Jan 12 '22 17:01 adamw

i rebased on upstream the master.

borissmidt avatar Jan 26 '22 18:01 borissmidt

@borissmidt Hm this looks like a correct PR. Did I somehow miss it, or was it lacking some development still?

adamw avatar Oct 31 '22 14:10 adamw

I was just 'cleaning' up my open PR's on github. I opened this a year ago so i can't remember exactly why it got stuck.

I think it was an issue with one of the scala3 macros. I didn't spend further time on this issue, because i stopped developing on the poc project.

borissmidt avatar Oct 31 '22 19:10 borissmidt