odelay icon indicating copy to clipboard operation
odelay copied to clipboard

feat: coverage for failed value computation

Open nimatrueway opened this issue 2 years ago • 3 comments

This simple use-case did not work

odelay.Delay(duration) { throw new TimeoutException() }.future

(if there were tests already in the repo I would have added one.)

nimatrueway avatar Oct 30 '23 18:10 nimatrueway

Thanks - I think the tests are here? https://github.com/softwaremill/odelay/blob/master/odelay-testing/src/test/scalajvm/TimerSpec.scala

adamw avatar Oct 31 '23 08:10 adamw

Thanks - I think the tests are here? https://github.com/softwaremill/odelay/blob/master/odelay-testing/src/test/scalajvm/TimerSpec.scala

Oops I missed them, thanks for the tip. I'll add one.

nimatrueway avatar Oct 31 '23 17:10 nimatrueway

There are some test failures

adamw avatar Nov 09 '23 20:11 adamw

There are some test failures

Sorry Adam, I fiddled with the tests a bit but didn't manage to fix it in 1hr. I have been hacking Scala for 7 years now but have never went through the pains of working on ScalaJS (like Future not having transformWith or not being about to match on types (e.g. case _: Assertion =>). I'm afraid learning it is not that useful either. I'll leave this to anyone who's interested to fix.

nimatrueway avatar Sep 03 '24 02:09 nimatrueway

@nimatrueway I think it's simply time to drop Scala 2.11 support :)

adamw avatar Sep 03 '24 12:09 adamw