codebrag icon indicating copy to clipboard operation
codebrag copied to clipboard

Published 20 hours ago • verified publisher icon softwaremill

Allfollowups

Open gmkumar2005 opened this issue 10 years ago • 6 comments

PR for resolving -- Tracking the followups #21 Adds a new Dashboard tab

image

gmkumar2005 avatar Dec 26 '14 07:12 gmkumar2005

I would rather call it Dashboard and do not restrict only to admins - all users should be able to view it.

lukaszlenart avatar Dec 29 '14 09:12 lukaszlenart

Renamed the allfollowups to Dashboard and will be visible to all users. Not sure how to re-factor the UI layer.
Renaming the controllers and methods may not be sufficient. The dashboard eventually would have additional functionality like.. statistics, search filters , graphs, etc.. All Followups service on server side could remain as is. Since it is a sub component of Dashboard I need an advice on how to organize the ui layer.

gmkumar2005 avatar Jan 05 '15 06:01 gmkumar2005

Not sure how to re-factor the UI layer.

I think the naming is ok - Dashboard can be treated as a virtual integration of several functions, ie. all followups, statistics, and so on. Let's start with something and see how it works.

lukaszlenart avatar Jan 05 '15 07:01 lukaszlenart

I'm reviewing and playing with this changes and one thing I'm not sure about is whether it's ok to reveal all comments' content to all users. If it's just to find out if there are pending reviews (followups not answered or not "done") it should be enough to just display number of all followups (maybe grouped by user too, e.g. john has 3 followups). What do you think?

mostr avatar Feb 09 '15 07:02 mostr

@mostr Lets walk thru a scenario . Given I am scrum master assisting the team to complete their tasks. I like to look at all the followups for a) Understand if code reviews are happening 2) Evaluate if the reviewer is able to review based on project guide lines say.. coding standards 3) Identify critical remarks and ensure high priority items get needed attention.

gmkumar2005 avatar Feb 09 '15 12:02 gmkumar2005

I'm checking out the changes. What I found out is that on Dashboard I can see all the followups, and I can press "OK THX" under each. It doesn't work, as I can't mark as done a followup which was not sent to myself, but the button should also not be visible.

Besides, I agree with @mostr that showing all the followups to all the users might be not necessary. Maybe there should be number of followups shown, but clickable, and unfolding the full text?

Also, I think number of commits waiting to review for each user should also be on Dashboard. If it's purpose is tracking project development.

amorfis avatar Jun 08 '15 11:06 amorfis