starknet.swift icon indicating copy to clipboard operation
starknet.swift copied to clipboard

Remove sncast json workaround in DevnetClient

Open DelevoXDG opened this issue 1 year ago • 3 comments

  • [x] https://github.com/foundry-rs/starknet-foundry/issues/678
  • [ ] Adjust to new sncast version

Blocked by: https://github.com/foundry-rs/starknet-foundry/pull/1093

DelevoXDG avatar Oct 30 '23 20:10 DelevoXDG

All right,to remove the JSON workaround in StarkNet, you can use native StarkNet data types and functions instead of converting data to JSON and back. This can make your code more efficient and easier to read. Hoping that This can help you to solve your problem. If you have any question, just ask me ;) .

Subbitoooo avatar Nov 01 '23 13:11 Subbitoooo

@Subbitoooo Hi, I'm not sure what are you referring to, as this issue is not related to converting Starknet data types, but to the output of the tool used internally for testing. This issue is dedicated to a workaround in DevnetClient, caused by the issue with cast tool mentioned in the description. This is a minor change and will be resolved in #114.

There are currently no any plans to refactor the way objects are serialized for interaction with JSON-RPC nodes.

DelevoXDG avatar Nov 01 '23 18:11 DelevoXDG

https://github.com/software-mansion/starknet.swift/issues/130

THenry14 avatar Jan 12 '24 11:01 THenry14