starknet.py icon indicating copy to clipboard operation
starknet.py copied to clipboard

Deploying with class hash

Open war-in opened this issue 2 years ago • 1 comments

Please check if the PR fulfills these requirements

  • [x] The formatter, linter, and tests all run without an error
  • [x] Tests for the changes have been added (for bug fixes/features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

It adds AccountClient's method deploy_contract which deploys with class_hash

What is the current behavior? (You can also link to an open issue here)

The only way of deployment is through Deploy transaction

What is the new behavior (if this is a feature change)?

...

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information

war-in avatar Sep 20 '22 09:09 war-in

Codecov Report

Base: 96.91% // Head: 96.97% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (870e909) compared to base (c830989). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #374      +/-   ##
===============================================
+ Coverage        96.91%   96.97%   +0.05%     
===============================================
  Files               45       48       +3     
  Lines             2336     2379      +43     
===============================================
+ Hits              2264     2307      +43     
  Misses              72       72              
Impacted Files Coverage Δ
starknet_py/contract.py 100.00% <100.00%> (ø)
starknet_py/net/udc_deployer/deployer.py 100.00% <100.00%> (ø)
starknet_py/utils/contructor_args_translator.py 100.00% <100.00%> (ø)
.../data_transformer/universal_deployer_serializer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 20 '22 10:09 codecov[bot]