starknet.py icon indicating copy to clipboard operation
starknet.py copied to clipboard

Add support for custom chain id

Open war-in opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe.

starknet.py supports custom starknet instances but doesn't support custom chain id

Describe the solution you'd like

@Arcticae will ask SW about this issue

war-in avatar Aug 09 '22 13:08 war-in

Please consider re-exporting ChainId as Union[StarknetChainId, int (or whichever the types suits the needs here)]

Arcticae avatar Aug 09 '22 14:08 Arcticae

This might be an easy change, since we're deprecating the chain from Clients anyway (it will only be a part of the signer).

cptartur avatar Aug 10 '22 08:08 cptartur

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 15 '22 14:09 stale[bot]