starknet.py icon indicating copy to clipboard operation
starknet.py copied to clipboard

Update `TypedData` in line with `SNIP-12`

Open NikitaMishin opened this issue 9 months ago • 3 comments

Feature Request

Do you guys plan to support snip-12

I see that currently only revision 0 supported https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-12.md https://github.com/software-mansion/starknet.py/blob/345b0ba9a5b717b6635783e9304784d586cd6d0e/starknet_py/net/models/typed_data.py#L17

NikitaMishin avatar May 14 '24 20:05 NikitaMishin

Hi @NikitaMishin Thank you for opening the issue. Could you please let me know if you need this implementation for a project you're currently working on?

ddoktorski avatar May 29 '24 08:05 ddoktorski

yes but not critical since we can use revision0 but for better user experience eventually good to have support of revision1

Hi @NikitaMishin Thank you for opening the issue. Could you please let me know if you need this implementation for a project you're currently working on?

NikitaMishin avatar May 29 '24 08:05 NikitaMishin

@NikitaMishin

I can confirm that we are going to work towards supporting SNIP-12. Unfortunately, I am unable to provide a timeline at the moment.

ddoktorski avatar Jun 04 '24 11:06 ddoktorski