starknet.py icon indicating copy to clipboard operation
starknet.py copied to clipboard

Change SierraContractClass abi return type

Open tkumor3 opened this issue 11 months ago • 1 comments

Closes #1306

  • change SierraCompiledContract abi type from string to AbiDictList and use marshmallow to verify it
  • add raw_abi abi in string. It's needed compute_sierra_class_hash

Introduced changes

  • [ ] This PR contains breaking changes

tkumor3 avatar Mar 06 '24 10:03 tkumor3

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.80%. Comparing base (0a2cbf2) to head (0f8d55c).

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1313      +/-   ##
===============================================
+ Coverage        97.10%   97.80%   +0.70%     
===============================================
  Files               94       94              
  Lines             4728     4743      +15     
===============================================
+ Hits              4591     4639      +48     
+ Misses             137      104      -33     
Files Coverage Δ
starknet_py/contract.py 97.68% <100.00%> (-0.01%) :arrow_down:
starknet_py/net/client_models.py 99.57% <94.44%> (-0.21%) :arrow_down:

... and 5 files with indirect coverage changes

codecov[bot] avatar Mar 06 '24 13:03 codecov[bot]

this seems like a breaking change, I suppose we should include this change in the migration guide. otherwise looks good.

It was a breaking change but I changed it as it was suggested in https://github.com/software-mansion/starknet.py/pull/1313#discussion_r1514680153

tkumor3 avatar Mar 13 '24 11:03 tkumor3