react-native-svg
react-native-svg copied to clipboard
fix: SVGs are filled with black instead of none (#2693)
Summary
This PR truly fixes issue https://github.com/software-mansion/react-native-svg/issues/2693 😄
Those changes fix multiple bugs:
extractedPropswere not forwarded to children ofRNSVGGroup- colors coming from
ASTwere already brushes fillwas not appended to thepropListwhendefaultFillwas used
Test Plan
Run any test involving SVG string parsing on Windows.
Compatibility
| OS | Implemented |
|---|---|
| Windows | ✅ |
| iOS | ✅ |
| MacOS | ✅ |
| Android | ✅ |
| Web | ✅ |
Checklist
- [x] I have tested this on a device and a simulator
- [ ] I added documentation in
README.md - [ ] I updated the typed files (typescript)
- [ ] I added a test for the API in the
__tests__folder
@bohdanprog, would you mind reviewing this PR when you have time? 😄