react-native-svg icon indicating copy to clipboard operation
react-native-svg copied to clipboard

fix: SVGs are filled with black instead of none (#2693)

Open ClaudiuHBann opened this issue 5 months ago • 1 comments

Summary

This PR truly fixes issue https://github.com/software-mansion/react-native-svg/issues/2693 😄

Those changes fix multiple bugs:

  • extractedProps were not forwarded to children of RNSVGGroup
  • colors coming from AST were already brushes
  • fill was not appended to the propList when defaultFill was used

Test Plan

Run any test involving SVG string parsing on Windows.

Compatibility

OS Implemented
Windows
iOS
MacOS
Android
Web

Checklist

  • [x] I have tested this on a device and a simulator
  • [ ] I added documentation in README.md
  • [ ] I updated the typed files (typescript)
  • [ ] I added a test for the API in the __tests__ folder

ClaudiuHBann avatar Jul 31 '25 22:07 ClaudiuHBann

@bohdanprog, would you mind reviewing this PR when you have time? 😄

ClaudiuHBann avatar Jul 31 '25 23:07 ClaudiuHBann