fix: prevent undefined override props from overriding SVG element props
Summary
That PR fixed issue #2693
This change prevents undefined values from being spread into the SVG component props, which could override existing props with undefined values.
expected result: https://www.svgviewer.dev/s/RCPYq8HE https://www.svgviewer.dev/s/lUyhreuZ
Test Plan
You can easily test that solution by running Test2693
Compatibility
| OS | Implemented |
|---|---|
| iOS | ✅ |
| MacOS | ✅ |
| Android | ✅ |
| Web | ✅ |
Checklist
- [x] I have tested this on a device and a simulator
- [ ] I added documentation in
README.md - [ ] I updated the typed files (typescript)
- [ ] I added a test for the API in the
__tests__folder
Hey @jakex7, could you take a look at that small PR, thanks ;)
@bohdanprog on my end it doesn't seem to be fixed, have you tested on windows as well?
@ClaudiuHBann Unfortunately, I don't have a Windows device. Could you check iOS or Android, please?
@bohdanprog I just tested on my Android device and it works great, I guess on iOS works as well, but on Windows remains the same, anyway LGTM! 😄
@ClaudiuHBann Well, maybe you should recompile the Windows source of SVG? I'm not familiar with Windows :( But we could try to find a way to solve that on Windows, too.
@ClaudiuHBann, please try to apply the patch and check if it solves the problem. my_custom_patch_file.patch updated.