react-native-screens icon indicating copy to clipboard operation
react-native-screens copied to clipboard

Published 20 hours ago • verified publisher icon software-mansion

feat: blurred modal background

Open henninghall opened this issue 4 years ago • 8 comments

Description

Introduces an option to blur screens behind a transparent modal.

So far only a POC on iOS, if you would like this feature I am happy to finalize the implementation by exposing a new prop and add android support.

Before

https://user-images.githubusercontent.com/1652607/104965523-2b104e00-59df-11eb-8d67-996e0eb280ff.mov

After

https://user-images.githubusercontent.com/1652607/104965510-264b9a00-59df-11eb-97d5-3b37110c2e1a.mov

henninghall avatar Dec 30 '20 11:12 henninghall

@WoLewicki Is this a feature you would like to have included in the project if finished? 😀

henninghall avatar Jan 15 '21 22:01 henninghall

Could you transfer the example to TestsExample project here too? I would be glad to test it for sure. Also, could you add a .mov with how does it look before applying these changes?

WoLewicki avatar Jan 18 '21 14:01 WoLewicki

@WoLewicki I transferred the example to TestExample and updated the description with before and after video.

henninghall avatar Jan 18 '21 21:01 henninghall

@WoLewicki Still waiting for your opinion on this 🙂

henninghall avatar Feb 03 '21 15:02 henninghall

Sorry for late response on this! Could you add something similar on Android transparent modals? We are aiming at having the consistent API between the platforms and this seems like a nice addition for sure! It would need to be controlled by some prop of the Screen component and would require some testing, but for sure it is worth adding.

WoLewicki avatar Mar 30 '21 13:03 WoLewicki

@henninghall @WoLewicki ideally the modal should close in the same way it opened. also does it behave the same way on android ?

a-eid avatar Mar 31 '21 10:03 a-eid

@WoLewicki Absolutely I will add it on Android as well, just wanted to confirm that this was a feature you would merge first. I will get back to work on this whenever I have the chance.

@a-eid How the modal open and close is not really related to this PR

henninghall avatar Apr 01 '21 10:04 henninghall

@henninghall it opens sliding up, it should probably slides down to close

current behavior is that it slides to open and fades to close.

a-eid avatar Apr 01 '21 10:04 a-eid