react-native-screens
react-native-screens copied to clipboard
software-mansion
fix: large header sizeToFit
Applied https://developer.apple.com/forums/thread/660745 solution suggested by @julian-baumann to make the large header appear on the Screen load. Should resolve #649 and #645.
Tried this patch but it seems like it's resizing the header back button instead of the title?
@nickyleach can you try and use the solution proposed here: https://github.com/software-mansion/react-native-screens/issues/645#issuecomment-712199841?
@nickyleach can you try and use the solution proposed here: #645 (comment)?
@WoLewicki the proposed solution is working for me.
@WoLewicki how can we help to merge it? We have to patch it in out code...
@savelichalex I am afraid the change proposed here was rather a quick workaround, not a solution to the problem, and so it might not be ever merged in order not to introduce any other bugs. I think it is better to apply https://github.com/software-mansion/react-native-screens/issues/645#issuecomment-712199841 as it seems to consistently solve the problem.
@WoLewicki the thing is we apply both that workarounds to get proper behaviour. If you look at gif above, you may notice that when it go back to settings screens the header is folded, though it shouldn't (you could see proper behaviour in default iOS settings app), and the change from current PR helps us to fix such problem.
Should I open a new issue for that? Or there are other ways how we could solve it? We are ready to contribute.
I still don't get why you need this PR. https://github.com/software-mansion/react-native-screens/issues/645#issuecomment-712199841 answers the issue of a folded header and this PR tries to do the same thing exactly.
@WoLewicki but what about Expo users? We need a native fix shipped with react-native-screens (if possible) to be included in SDK 41. Patching isn't an option for folks like me, because I love the managed experience. (Even though downsides are that I am sometimes handcuffed)
This PR is not a solution to the problem, rather a workaround, which can result in other bugs, so we most probably don't want to merge it unfortunately. I believe the real solution is the change of react-native implementation. If you need this with Expo managed workflow, can't you use the workarounds using JS code pointed in the connected issue?
I have no easy solution for this then unfortunately. Probably when EAS comes live for everyone, it will be simpler to patch native code for managed workflow.