react-native-screens icon indicating copy to clipboard operation
react-native-screens copied to clipboard
verified publisher icon software-mansion

chore(Android): update spotless & ktlint

Open kkafar opened this issue 1 year ago • 5 comments

Description

Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps.

Changes

Ktlint: 0.43 -> 1.1.1 spotless 6.11 -> 6.22

Checklist

  • [ ] Ensured that CI passes

kkafar avatar Feb 27 '24 07:02 kkafar

Yeah, I was waiting for this being released & it happened with release of ktlint 1.2.0 few hours ago. -> I bumped it, let's see whether it will work now.

kkafar avatar Feb 29 '24 10:02 kkafar

Because of the new version of ktlint, I see that some of new rules have been introduced that changes the way how we're writing the code. @kkafar should we disable some of them, or leave the changes as they are? What do you think?

tboba avatar Mar 05 '24 14:03 tboba

I'll get back to this PR tomorrow, resolve conflicts.

If some rules changed we should just reformat the whole kotlin codebase according to new rules. This should not be problematic as all it would require for branches behind main to do is to cherry-pick this commit & run (for example).

kkafar avatar Apr 16 '24 14:04 kkafar