react-native-screens icon indicating copy to clipboard operation
react-native-screens copied to clipboard

chore: migrate codegen to TypeScript

Open kkafar opened this issue 3 years ago • 0 comments

Description

Issues

  • activityState is set to 0.0 by default in codegened files despite being explicitly set to WithDefault<Float, -1.0> in config (it should be -1.0). Tested it multiple times it looks like you can't set number < 0 for default when using TypeScript - tested with both Int32 and Float (with Flow it worked fine).
  • yarn lint fails

There are no other differences between codegened files -- I checked it file by file with diff tool.

Update: It was confirmed by React Native developer that this indeed is a bug and will be fixed with 0.71.

Changes

Test code and steps to reproduce

Checklist

  • [ ] Included code example that can be used to test this change
  • [ ] Updated TS types
  • [ ] Updated documentation:
    • [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
    • [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
    • [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
    • [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
  • [ ] Ensured that CI passes

kkafar avatar Sep 27 '22 08:09 kkafar