react-native-screens icon indicating copy to clipboard operation
react-native-screens copied to clipboard

Back button subivew is not yet Fabric compatible in react-native-screens

Open gemcoder21 opened this issue 2 years ago • 7 comments

Description

<Stack.Screen
   headerLeft: () => (
     <Button
       onPress={() => navigation.navigate(Screen.Settings)}
       title="Info"
     />
     ),
   })}
/>

Steps to reproduce

  1. Add headerLeft option to any screen and it will trigger an error in the console.
Screenshot 2022-08-18 at 18 07 29

Snack or a link to a repository

--

Screens version

3.15.0

React Native version

0.69.4

Platforms

iOS

JavaScript runtime

No response

Workflow

No response

Architecture

No response

Build type

No response

Device

No response

Device model

No response

Acknowledgements

Yes

gemcoder21 avatar Aug 19 '22 01:08 gemcoder21

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Snack or a link to a repository section.

github-actions[bot] avatar Aug 19 '22 01:08 github-actions[bot]

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

github-actions[bot] avatar Aug 19 '22 01:08 github-actions[bot]

<Stack.Screen
   headerRight: () => (
     <Button
       onPress={() => navigation.navigate(Screen.Settings)}
       title="Info"
     />
     ),
   })}
/>

Right button works just fine. I wonder if there is a work around.

gemcoder21 avatar Aug 19 '22 01:08 gemcoder21

Hi @endlessl8p, I'm aware of this missing feature, it will be added soon and released most likely with 3.17.0. Thank you for reporting.

kkafar avatar Aug 19 '22 07:08 kkafar

Hello @kkafar, I am running into this issue on react-native-screens v3.18.0. Is there an update on when this fix will come out? Thanks!

myou11 avatar Oct 10 '22 19:10 myou11

@myou11, I remember that I encountered some issues with Fabric view-flattening while I was trying to resolve this issue and moved to other stuff. I won't give you any specifics, but I did not forgot about this issue and will be back on it before 3.19.0.

kkafar avatar Oct 11 '22 11:10 kkafar

gotcha! thanks for the update, looking forward to 3.19!

myou11 avatar Oct 11 '22 18:10 myou11

Any updates/estimates on this issue? @kkafar

gemcoder21 avatar Dec 01 '22 22:12 gemcoder21

facing same issue.. is there any update on this?

sushant-sahoo avatar Jan 12 '23 17:01 sushant-sahoo

@kkafar would you be able to push new release with this fix?

gemcoder21 avatar Feb 10 '23 23:02 gemcoder21

"react-native": "0.71.3", "react-native-screens": "^3.20.0",

use new arch There is still this problem

dppo avatar Feb 16 '23 07:02 dppo