react-native-screens icon indicating copy to clipboard operation
react-native-screens copied to clipboard

FullWindowOverlay not fitting the window

Open nazrdogan opened this issue 2 years ago • 5 comments

I m trying to use FullWindowOverlay to show a custom action sheet in the modal screen. but FullWindowOverlay has some spaces at the bottom. In our app, I edited react-native-screens/ios/RNSFullWindowOverlay.m ( version: 3.10.1) like this way. it seems working for me. but I m not sure this is the right way to do

- (void)reactSetFrame:(CGRect)frame
{
  _reactFrame = frame;
  CGRect rect = [[UIScreen mainScreen] bounds];
  [_container setFrame:rect];
}

https://snack.expo.dev/@nazrdogan/suspicious-coffee

Image from iOS

nazrdogan avatar Dec 25 '21 21:12 nazrdogan

I believe it is a duplicate of #1202 (check if https://github.com/software-mansion/react-native-screens/issues/1202#issuecomment-981755351 resolves the issue). As for adding such code, it may be a good point to just make it fullscreen by default, could you make a PR with this change and this reproduction in TestsExample app ?

WoLewicki avatar Jan 03 '22 13:01 WoLewicki