react-native-screens icon indicating copy to clipboard operation
react-native-screens copied to clipboard

fix: overlay in fullscreen modal

Open WoLewicki opened this issue 2 years ago • 2 comments

Description

When the fullScreenModal is presented, the FullWindowOverlay is removed from native view hierarchy since the view receives didMoveToWindow with nil value. This behavior can be removed, but then the only way to remove it will be to invalidate it, which means removing the component on the react side. Such change would result e.g. in view not disappearing when moving between screens of navigators since these screens are not removed from the React view hierarchy.

Test code and steps to reproduce

Test1096.tsx in TestsExample app.

Checklist

  • [x] Included code example that can be used to test this change
  • [ ] Ensured that CI passes

WoLewicki avatar Oct 28 '21 09:10 WoLewicki

Any updates on this?

gabrieldonadel avatar Mar 16 '22 20:03 gabrieldonadel

This PR introduces some changes that are breaking the old behavior, so I am not sure if it will be merged. You can always use patch-package and apply those changes in your app if you need them.

WoLewicki avatar Mar 17 '22 09:03 WoLewicki