react-native-screens icon indicating copy to clipboard operation
react-native-screens copied to clipboard

fix: keyboard avoiding view behaviour on swipe

Open kacperkapusciak opened this issue 2 years ago • 2 comments

Description

This PR fixes the wrong behaviour of keyboard avoiding view.

Fixes https://github.com/react-navigation/react-navigation/issues/9920

Changes

  • Call endEditing during swiping logic in viewWillDisappear

Screenshots / GIFs

Native behavior (UIkit)

https://user-images.githubusercontent.com/39658211/137096277-644f8dfe-b857-4932-8f76-c4ae5ef6d9d0.mp4

Before

https://user-images.githubusercontent.com/39658211/136337558-a438b876-e93c-4df9-90de-6fa92caa5bf6.mp4

After

Test code and steps to reproduce

Test1168.tsx

Checklist

  • [x] Included code example that can be used to test this change
  • [ ] Updated TS types
  • [ ] Updated documentation:
    • [ ] https://github.com/software-mansion/react-native-screens/blob/master/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
    • [ ] https://github.com/software-mansion/react-native-screens/blob/master/native-stack/README.md
    • [ ] https://github.com/software-mansion/react-native-screens/blob/master/createNativeStackNavigator/README.md
    • [ ] https://github.com/software-mansion/react-native-screens/blob/master/src/types.tsx
    • [ ] https://github.com/software-mansion/react-native-screens/blob/master/src/native-stack/types.tsx
  • [ ] Ensured that CI passes

kacperkapusciak avatar Oct 07 '21 07:10 kacperkapusciak

Is something holding this back?

hirbod avatar Jul 15 '22 13:07 hirbod

cc @kacperkapusciak

WoLewicki avatar Jul 18 '22 09:07 WoLewicki