react-native-reanimated
react-native-reanimated copied to clipboard
software-mansion
Warn users to not use LayoutAnimation
in its current state, until the rewrite has been released. This issue is too impactful and it should be warned until its resolved.
Description
Changes
Test code and steps to reproduce
Checklist
- [ ] Included code example that can be used to test this change
- [ ] Updated TS types
- [ ] Added TS types tests
- [ ] Added unit / integration tests
- [ ] Updated documentation
- [ ] Ensured that CI passes
The problem with deallocation of objects occurs only for absolutely positioned components such as modal. Right, It is an important issue but IMO not as important to discourage the use of Layout Animation in every case. Especially since we almost fixed it.
I disagree on this one, since a single use is enough to crash your app. And it does also interfere with other libs like react-native-svg on android (massive duplication of nodes). I think a note about the pitfalls should be set. I've encountered plenty of users been stuck on "magical issues" that have been caused by this. I did not add this to trash talk anybody nor throw a bad light, you know I love what you guys are doing. I just think that as long as this issues are persistent and not fixed (also remember fixed versions of Expo), there has to be a warning.
Agreed with @hirbod , a single usage of this (even with the patch in place) can cause plenty of issues across an application. Especially since we almost fixed it is not true in practice, been running this in prod for awhile with plenty of weird behaviour and crashes both iOS and Android side (with a simple implementation of the feature).
I had to implement custom native fixes myself to patch some of them, many developers who have not spent lots of time debugging these issues would have no clue what is happening. I love what the SM team is doing as well - you guys save us countless hours of work with these libraries. Yet not even warning users about this seems slightly careless
This is such a simple yet important MR. I love SW as well, but this is such an insidious issue, and until it's fixed, it's borderline unethical to knowingly leave it without any warning to users. I've been following the GitHub issues associated with this for months now, as I assumed such a substantial issue would be addressed with some urgency, but there hasn't been any movement.
This is fine. You guys are doing great work for the community, and your priorities are yours alone. But adding a warning seems like the responsible thing to do at this point.
