react-native-gesture-handler
react-native-gesture-handler copied to clipboard
Remove hammer.js
Hammer.js introduces a lot of extra code bloat, doesn't support SSR, and the repo is now pretty unmaintained. Opening this issue to mark that we do plan on replacing it eventually.
It might even make sense to migrate a few recognizers at a time.
Related issues #786 #883 #800
whats gonna be hammerjs's replacement?
Perhaps we could replace it with @egjs/hammerjs, which is pretty much a drop-in replacement that supports SSR and that is maintained?
Hi @EvanBacon , I see this was already done in https://github.com/software-mansion/react-native-gesture-handler/commit/e4de5d9156fba4f60a8b8c435677c552806f8a25#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
But can I ask that you avoid the github source dependency please, this breaks our build because our docker build does not have git, as a security precaution. At the very least you should use a specific tag, so you're not just installing "latest" at build time, but really this is the only package we have that has a git dependency, so it only started breaking this week. It's been a hell of a time tracking this down, as yarn wouldn't tell me what it was trying to do, only that it couldn't find git.
For the meantime I'm having to keep our version down until it's fixed.
Thanks!