react-native-gesture-handler icon indicating copy to clipboard operation
react-native-gesture-handler copied to clipboard

Confusing behavior of RN responder when used with RNGestureHandler needs to be documented

Open thomasttvo opened this issue 1 year ago • 2 comments

Description

We noticed that in RN, onShouldBlockNativeResponder does NOT have any effect on iOS. This is also mentioned in RN documentation. However, when a RN View is used inside RNGestureHandler, returning true in onShouldBlockNativeResponder DOES have an effect on iOS. This difference between RN and RNGestureHandler caused a bit of confusion and should probably be documented.

Upon investigating further, it looks like RNGestureHandler is replacing RN setJSResponder here with its own. Are there other differences in behaviors because of that? I think all these differences should be documented

Update: Looks like the Meta team said replacing setJSResponder is "guaranteed to break in the new architecture"

Gesture Handler version

2.11.0

React Native version

0.71

Platforms

iOS

JavaScript runtime

Hermes

Workflow

non-expo

Architecture

New

Acknowledgements

Yes

thomasttvo avatar Oct 10 '23 18:10 thomasttvo

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Steps to reproduce and Snack or a link to a repository sections.

github-actions[bot] avatar Oct 10 '23 18:10 github-actions[bot]

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

github-actions[bot] avatar Oct 10 '23 18:10 github-actions[bot]