protostar icon indicating copy to clipboard operation
protostar copied to clipboard

Add Uint256 strategy

Open Radinyn opened this issue 2 years ago • 1 comments

Radinyn avatar Oct 12 '22 10:10 Radinyn

Codecov Report

Base: 84.35% // Head: 84.15% // Decreases project coverage by -0.20% :warning:

Coverage data is based on head (991b956) compared to base (7bcfb01). Patch coverage: 82.50% of modified lines in pull request are covered.

:exclamation: Current head 991b956 differs from pull request most recent head 3f259ef. Consider uploading reports for the commit 3f259ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
- Coverage   84.35%   84.15%   -0.21%     
==========================================
  Files         279      277       -2     
  Lines        9699     9519     -180     
==========================================
- Hits         8182     8011     -171     
+ Misses       1517     1508       -9     
Impacted Files Coverage Δ
protostar/testing/fuzzing/strategies/uint256.py 73.07% <73.07%> (ø)
protostar/testing/fuzzing/strategies/__init__.py 86.66% <100.00%> (+0.95%) :arrow_up:
protostar/testing/fuzzing/strategy_descriptor.py 65.38% <100.00%> (ø)
protostar/testing/fuzzing/strategy_inference.py 100.00% <100.00%> (ø)
...otostar/testing/fuzzing/strategy_inference_test.py 100.00% <100.00%> (ø)
...tar/commands/migrate_configuration_file_command.py 64.00% <0.00%> (-28.31%) :arrow_down:
protostar/cli/network_command_util.py 83.33% <0.00%> (-12.23%) :arrow_down:
...lf/protostar_compatibility_with_project_checker.py 93.10% <0.00%> (-1.90%) :arrow_down:
protostar/testing/cheatcodes/store_cheatcode.py 42.30% <0.00%> (-1.70%) :arrow_down:
protostar/starknet/cheatable_cached_state.py 73.07% <0.00%> (-1.32%) :arrow_down:
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 12 '22 10:10 codecov[bot]

I'd also ask @mkaput since he's the fuzzing specialist 😬

Arcticae avatar Oct 19 '22 16:10 Arcticae

As discussed on the meeting, will be merged in it's current state.

Radinyn avatar Dec 07 '22 10:12 Radinyn

@Radinyn Are docs updated about this? Also if it is a breaking change we should mention it in changelog

MaksymilianDemitraszek avatar Dec 08 '22 08:12 MaksymilianDemitraszek

No it's a new feature. Good point about the docs.

Radinyn avatar Dec 08 '22 09:12 Radinyn

@Radinyn Can you create task for it and add it to this milestone?

MaksymilianDemitraszek avatar Dec 08 '22 12:12 MaksymilianDemitraszek