protostar icon indicating copy to clipboard operation
protostar copied to clipboard

Published 20 hours ago • verified publisher icon software-mansion

Fix constants.json handling when using unbuild Protostar in development

Open mkaput opened this issue 2 years ago • 3 comments

image

mkaput avatar Oct 18 '22 14:10 mkaput

@kasperski95 was that not fixed?

Arcticae avatar Oct 18 '22 19:10 Arcticae

Protostar doesn't crash, so it's fixed to me.

Loading constants.json in the unbuild version of Protostar requires a different logic.

kasperski95 avatar Oct 19 '22 08:10 kasperski95

I actually think that there shouldn't be any extra logic. The constants.json file can be loaded with importlib.resources module, which should work both in built, and unbuilt cases.

mkaput avatar Oct 19 '22 08:10 mkaput