Varun Malhotra

Results 37 comments of Varun Malhotra

@konsultaner Could you please help in maintaining the coverage as well by adding test cases for the new code?

@fonkgoku @4F2E4A2E Sure. kinda busy with office work, will check this weekend surely. Meanwhile, can you please take out some time to write some test cases for the new code...

I have reviewed the PR and left some comments. Addressing those comments would ensure the library would be working fine with both the types. Also, since we have examples too,...

Any updates @fonkgoku ? Please let me know if you need any help from my side.

Using `removeAll` deletes all the keys created by secure-ls lib. Please refer the [docs](https://github.com/softvar/secure-ls/#methods). Please let me know if it causes any issue.

I think there's some issue for sure. WIll debug and let you know. Thanks for reporting this.

Users can encode it and use accordingly. But I like your point of encrypting it before saving it as meta info in `localStorage`.

Thanks for pointing this out. Will look into it.

Hi @ullalaaron No, it is not possible to provide a custom id. Though you can provide a custom name to the opened window by setting `window.name` or `window.windowName`. Check this...

Yes, by default it opens in the same window only i.e. as a tab (which is why across-tabs :) ). ``` var config = { url: 'child.html', windowName: 'child-tab-' +...